Add authn #1
Merged
Add authn #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcfarlane
commented
Nov 1, 2023
emcfarlane
commented
Nov 3, 2023
|
|
||
| // BasicAuth returns the username and password provided in the request's | ||
| // Authorization header, if any. | ||
| func (r Request) BasicAuth() (username string, password string, ok bool) { |
There was a problem hiding this comment.
This is new, helper for basic auth that just delegates to the request.
akshayjshah
approved these changes
Nov 21, 2023
|
|
||
| // Request describes a single RPC invocation. | ||
| type Request struct { | ||
| request *http.Request |
There was a problem hiding this comment.
This is a nice change! Also opens the door for us to expose cookies, which are annoyingly tied to http.Request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add authn package. Based off of https://github.com/akshayjshah/connectauth.
Changes:
r.BasicAuth()without the overhead on every request. Should be extensible down the line to add more helpers likeBearerAuth()etc.TLS()method to enable authFunc to check TLS settings